Weapons need base critical chances imo, at least weapons like daggers, guns, bows and katanas. Maybe lower chance/critical damage modifiers on long/shortswords (not broadswords) and blunt/heavy melees don't crit at all unless you socket the appropriate rune into them.